Repository navigation
perf: don't keep multiple copies of the same mail data in memory - #232
Merged
Merged
Conversation
j-g00da
commented
Sep 11, 2026
Collaborator
Author
|
The main improvement is that envelope data is no longer cloned to each worker, which can be problematic on e.g. large groups with people using many different relays. Reduces memory usage of worker queues. |
j-g00da
force-pushed
the
j-g00da/limit-mail-data-clones
branch
from
September 11, 2026 07:23
5ea2370 to
6ff0d69
Compare
Uses `Bytes` instead of `Vec<u8>`, to prevent keeping multiple copies of messages in memory. Signed-off-by: Jagoda Ślązak <jslazak@jslazak.com>
j-g00da
force-pushed
the
j-g00da/limit-mail-data-clones
branch
from
September 11, 2026 07:27
6ff0d69 to
d4c9d12
Compare
link2xt
approved these changes
Sep 11, 2026
j-g00da
added a commit
that referenced
this pull request
Sep 11, 2026
Leftover I forgot to remove in #232, this prevents cloning the inner data. Signed-off-by: Jagoda Ślązak <jslazak@jslazak.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses
Bytesinstead ofVec<u8>,to prevent keeping multiple copies of messages
in memory.